Support building of loadtest apps with locally installed dependencies #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To build for arm64 without adding another SDL, assimp and glew to other_lib. * Fix location of testimages for installed app. * Rationalize include directories for appfwSDL and GLAppSDL. Required because my x64 Windows laptop has become too slow for practical use.
Fix error in tag filter in all workflow files.
Fix typo in windows.yml.
ls WinSDK to help debug glu32.lib issue.
Add more logging. Clean up.
Remove CPU_ARCHITECTURE hack from SDL2_FOUND.
Use major version to decide directory to list. Add retry loop around NSIS install.
Silence errors on ls commands so script doesn't fail when no file.
- Print message about existence of CMP049. - Modify error action on ls in build_win.ps1 - REQUIRE OpenGL. - Add warning comment about genexes.
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 22, 2024
…KhronosGroup#799) to allow building on Windows arm64 without adding more binaries to `other_lib`. * Rationalize include file search directories for appfwSDL, GLAppSDL and glloadtests. * Set up to build loadtest apps for arm64 in Windows CI. Disabled because the Windows SDK chosen by CMake does not contain a needed library and I have yet to find a way to force selection of the latest SDK which does include it. * Set up x86_64 macOS CI builds to use Brew-installed dependencies. Other items emerged during this work. * Fix Windows' loadtest apps to find their resources when run. * Fix inability to debug libktx on Windows caused by both `ktx.exe` and `ktx.dll` trying to use `ktx.pdb`. * Fix syntax error in tag selection in Actions .yml files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to allow building on Windows arm64 without adding more binaries to
other_lib.glloadtests.
the Windows SDK chosen by CMake does not contain a needed library and
I have yet to find a way to force selection of the latest SDK which includes it.
Other items emerged during this work.
ktx.exeandktx.dlltrying to use
ktx.pdb.